Conversation
r0b1n
force-pushed
the
ai/release-info-script
branch
from
07920ac to
7f00790
Compare
Comment on lines
+83
to
+89
| const unreleased = changelog.changelog.content[0]; | ||
| return unreleased.sections.flatMap(section => | ||
| section.logs.map(log => ({ | ||
| type: section.type, | ||
| description: log | ||
| })) | ||
| ); |
Contributor
There was a problem hiding this comment.
If a changelog has no entries at all, content[0] is undefined and this throws. Should guard: if (!unreleased) return []
| } | ||
|
|
||
| interface ChangelogEntry { | ||
| type: "Fixed" | "Added" | "Changed" | "Removed" | "Breaking changes"; |
Contributor
There was a problem hiding this comment.
Here you mention the breaking changes type, but the release-candidates.ts file does not have it https://github.com/mendix/web-widgets/pull/2176/changes#diff-455469ccfc1eb8c253d3958fc6b9424447d549592886eb89d125c08ff6cf60e6R14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.