Fix Heltec Wireless Paper battery reading#2164
Merged
liamcottle merged 4 commits intomeshcore-dev:devfrom Apr 12, 2026
Merged
Conversation
Trahomich
pushed a commit
to Trahomich/MeshCore
that referenced
this pull request
Mar 31, 2026
- Extract hardcoded ADC multiplier (5.42) into ADC_MULTIPLIER macro - Add ADC_MULTIPLIER=8.4 for Heltec Wireless Paper variant - Default ADC_MULTIPLIER=5.42 for Heltec V3 (unchanged behavior) Based on upstream PR meshcore-dev#2164 by Snayler
|
Where can I download a beta of this to test this out on a device? |
Member
|
Hey, thanks for the contribution! Merging in :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got tired of waiting for #1584 and #1264 to fix the issues so I created this PR from the information on #1584. I decided to use @oltaco suggestion as it looks cleaner. No need to define ADC_MULTIPLIER for heltec_v3 and heltec_tracker tho, as they will use the default value.