Fix SanityCheck: adapt to LlmModule.load() void return#236
Open
psiddh wants to merge 1 commit intometa-pytorch:mainfrom
Open
Fix SanityCheck: adapt to LlmModule.load() void return#236psiddh wants to merge 1 commit intometa-pytorch:mainfrom
psiddh wants to merge 1 commit intometa-pytorch:mainfrom
Conversation
LlmModule.load() now returns void and throws ExecutorchRuntimeException on failure (changed in pytorch/executorch#18669). Remove the return value capture and assertEquals check — a successful load() call without exception is the assertion. This commit was authored with the help of Claude.
meta-cla
Bot
added
the
CLA Signed
There was a problem hiding this comment.
Pull request overview
Updates the Android instrumentation sanity test to align with the upstream API change where LlmModule.load() no longer returns a status code and instead signals failure via exception.
Changes:
- Removes the captured return value from
LlmModule.load()and the associatedassertEqualscheck. - Relies on “no exception thrown” as the success condition for model loading.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LlmModule.load() now returns void and throws ExecutorchRuntimeException on failure (changed in pytorch/executorch#18669). Remove the return value capture and assertEquals check — a successful load() call without exception is the assertion.