fix: Use toLowerCase() consistently for event name normalization#180
Open
YunchuWang wants to merge 1 commit intomainfrom
Open
fix: Use toLowerCase() consistently for event name normalization#180YunchuWang wants to merge 1 commit intomainfrom
YunchuWang wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a locale-dependent mismatch in external event name normalization in the DurableTask JS orchestration runtime to prevent waitForExternalEvent() from hanging indefinitely in certain locales (e.g., Turkish), aligning behavior with the executor and preserving orchestration determinism.
Changes:
- Normalize external event names using
toLowerCase()(instead oftoLocaleLowerCase()) inRuntimeOrchestrationContext.waitForExternalEvent(). - Add executor regression tests for case-insensitive external event matching, including the “buffered event arrives before wait” scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/durabletask-js/src/worker/runtime-orchestration-context.ts | Switches event-name normalization to locale-independent toLowerCase() to match executor behavior and avoid nondeterminism. |
| packages/durabletask-js/test/orchestration_executor.spec.ts | Adds regression tests intended to validate case-insensitive event name matching across the wait/raise boundary (including buffered events). |
You can also share your feedback on Copilot code review. Take the survey.
YunchuWang
force-pushed
the
copilot-finds/bug/fix-event-name-locale-mismatch
branch
from
92623d4 to
a69f93a
Compare
…matching waitForExternalEvent() used toLocaleLowerCase() to normalize event names, while handleEventRaised() in the orchestration executor used toLowerCase(). In locales where these produce different results (e.g., Turkish 'I' -> dotless 'ı' vs 'i'), event names registered by waitForExternalEvent would not match events delivered by the executor, causing orchestrations to hang indefinitely. This also violates the determinism invariant: the same orchestration code running on machines with different locale settings would produce different event name keys, potentially breaking replay. The fix changes toLocaleLowerCase() to toLowerCase() in waitForExternalEvent() to be consistent with the executor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
YunchuWang
force-pushed
the
copilot-finds/bug/fix-event-name-locale-mismatch
branch
from
a69f93a to
f56785f
Compare
YunchuWang
added
ready for review
pending-verification
and removed
ready for review
labels
github-actions bot
pushed a commit
that referenced
this pull request
Apr 15, 2026
Verification sample: examples/verification/pr-180-event-name-locale.ts Scenario: External event name matching with mixed case names works correctly after switching from toLocaleLowerCase() to toLowerCase(). Validates that orchestrations waiting for UPPER_CASE event names receive events raised with lowercase names. Generated by pr-verification-agent Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
added
sample-verification-added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #171
Problem
waitForExternalEvent() in runtime-orchestration-context.ts uses toLocaleLowerCase() to normalize event names, while handleEventRaised() in orchestration-executor.ts uses toLowerCase(). These produce different results in certain locales (e.g., Turkish), causing orchestrations to hang indefinitely.
Changes