Add theme support for customizable colors#801
Open
FlipFlopszzz wants to merge 1 commit intomicrosoft:mainfrom
Open
Add theme support for customizable colors#801FlipFlopszzz wants to merge 1 commit intomicrosoft:mainfrom
FlipFlopszzz wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
Unfortunately, I'm not sure if we can merge this. My vision was to introduce a CSS-like language for theming of the application. I briefly mention this here: Lines 86 to 87 in 7c0b3d1 A while ago I had started a prototype in this branch: https://github.com/microsoft/edit/tree/dev/lhecker/css |
Author
|
I honestly just need a way to customize colors, don't care about the implementation details. Your CSS plan definitely sounds more robust. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add theme support for customizable colors, format: RGB/RGBA
Example config
{ "theme": { "black": "#000000", "red": "#FF0000FF", "green": "#00FF00", "yellow": "#FFFF00FF", "blue": "#204DBE", "magenta": "#FF00FFFF", "cyan": "#00A7B2", "white": "#FFFFFFFF", "brightBlack": "#808080", "brightRed": "#FF3E30FF", "brightGreen": "#58EA51", "brightYellow": "#FFC944FF", "brightBlue": "#2F6AFF", "brightMagenta": "#FC74FFFF", "brightCyan": "#00E1F0", "brightWhite": "#FFFFFFFF", "background": "#0C0C0C", "foreground": "#00FF00FF", "lineNumber": "#FF00FF", "lineHighlight": "#00FF00FF" } }Scope
This is a lightweight change with no new dependencies.
The changes are limited to:
Validation
cargo test -q
Notes
Only tested on Windows 11 with cargo 1.86.0
Screenshot