Fix zero-width regex replacements#808
Open
lawrence3699 wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
|
@lawrence3699 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #775.
Replacing a zero-width regex match currently relies on having an active selection.
That works for normal matches, but patterns like
$produce an empty match, so the selection is cleared and both Replace and Replace All turn into no-ops.This change keeps track of the active regex match separately from the visible selection so zero-width matches can still be replaced.
After replacing an empty match, Replace All now advances past the next grapheme (or forces a wrap at EOF) so it does not get stuck on the same logical position.
The cached zero-width match is also ignored once the cursor moves away, so Replace does not insert at a stale location.
Validation: