chore(fast-html): use @microsoft/fast-build to build when fixture with lowercase attrs#7380
Open
chore(fast-html): use @microsoft/fast-build to build when fixture with lowercase attrs#7380
Conversation
Collaborator
Author
|
Updated to pass state attributes to the nested-when element. Now builds successfully with the renderer fix in #7396 (kebab-to-camelCase attribute mapping). |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Use lowercase no-dash attribute names (e.g. vara, thisvar, thatvar, showprogress, enablecontinue) to match the SSR crate's lowercasing behaviour and to avoid hyphen-separated state keys that would not match the camelCase template expressions. - main.ts: update @attr declarations to use no-dash attribute names - entry.html: replace dash-case attrs with lowercase no-dash equivalents - templates.html: update f-when expressions to use lowercase state keys - index.html: regenerated via npm run build:fixtures Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
janechu
force-pushed
the
users/janechu/update-fixture-to-use-fast-build-when
branch
from
8e19d1e to
6149a56
Compare
janechu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
@microsoft/fast-buildto generate theindex.htmlfor thewhentest fixture in@microsoft/fast-html.Changes
whenfixture to thebuild-fixtures.jsscript so it is generated by the SSR crate alongsideattribute,binding, andeventfixtures.entry.htmlfrom dash-case to lowercase no-dash form (e.g.var-a→vara,this-var→thisvar,show-progress→showprogress) to match the lowercasing behaviour of@microsoft/fast-build, which lowercases all attribute keys before storing them in child element state.main.ts@attrdeclarations to use the matching no-dash attribute names.templates.htmltemplate expressions to use the same lowercase no-dash keys (e.g.{{varA == 3}}→{{vara == 3}},{{showProgress}}→{{showprogress}}).index.htmlvianpm run build:fixtures.