Skip to content

fix: #902 stabilize testCompletionErrorOnMissingContext#903

Open
ashakirin wants to merge 2 commits intomodelcontextprotocol:mainfrom
ashakirin:fix/902-stabilize-testCompletionErrorOnMissingContext
Open

fix: #902 stabilize testCompletionErrorOnMissingContext#903
ashakirin wants to merge 2 commits intomodelcontextprotocol:mainfrom
ashakirin:fix/902-stabilize-testCompletionErrorOnMissingContext

Conversation

@ashakirin
Copy link
Copy Markdown
Contributor

fix: #902 stabilize testCompletionErrorOnMissingContext with client retry logic

@Kehrlann Kehrlann self-assigned this Apr 8, 2026
@Kehrlann
Copy link
Copy Markdown
Contributor

Kehrlann commented Apr 8, 2026

@ashakirin the retry seems a bit overkill.

It seems we use .close() on the client with a try-with-resources. By default, this does .closeGracefully().subscribe(), which starts the closing process but doesn't wait.

Should we try and use StepVerifier.create(transport.closeGracefully()).verifyComplete(); instead?

@Kehrlann Kehrlann added the tests Addresses tests only label Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Addresses tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize flaky test: McpCompletionTests.testCompletionErrorOnMissingContext

2 participants