Open
Conversation
Author
|
I still try to figure out the cli of openproblems. So I did the PR without proper local testing. |
Author
|
Seems to fail now at the point again where spatialdata object is created for cellpose. So the dataprocessor is kinda done. |
Member
|
For process_dataset, the logs say: Is it expected that the output doesn't have an image, as requested by the api? https://github.com/openproblems-bio/task_spatial_segmentation |
Author
|
Yeah, I did some weird stuff. I made now the proper change and commented out, because so far I dont fully know if the spatialdata needs standard processing. Only the single cell data needs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Refining the base repo. Filling in also the data_processor stuff.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!