-
Notifications
You must be signed in to change notification settings - Fork 605
OCPSTRAT-3036: Rebase 1.36 #2813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jubittajohn
wants to merge
10
commits into
openshift:master
Choose a base branch
from
jubittajohn:rebase-1.36
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d134fd5
bump(k8s): tools: update k8s.io/* dependencies to v0.36.0-rc.1
jubittajohn ece9512
bump(k8s): update k8s.io/* dependencies to v0.36.0-rc.1
jubittajohn b587d45
bump(k8s): remove deprecated autoscaling v2beta1/v2beta2 and scheduli…
jubittajohn c438f38
bump(k8s): tools: go mod vendor
jubittajohn 2f3e9c7
bump(k8s): go mod vendor
jubittajohn 3a72708
bump(k8s): tools: align to new upstream function by removing Bounding…
jubittajohn e8cf7ba
bump(k8s): update builder images
jubittajohn f83e4ca
bump(k8s): make update
jubittajohn 7b34b4a
bump(k8s): tests: update k8s.io/* dependencies to v0.36.0-rc.1
jubittajohn 49d4cc1
bump(k8s): tests: go mod vendor
jubittajohn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| build_root_image: | ||
| name: release | ||
| namespace: openshift | ||
| tag: rhel-9-release-golang-1.25-openshift-4.22 | ||
| name: openshift-build | ||
| namespace: jasee | ||
| tag: rhel-9-golang-1.25 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/api
Length of output: 339
🏁 Script executed:
Repository: openshift/api
Length of output: 799
🏁 Script executed:
Repository: openshift/api
Length of output: 76
🏁 Script executed:
Repository: openshift/api
Length of output: 39
🏁 Script executed:
Repository: openshift/api
Length of output: 1147
🏁 Script executed:
Repository: openshift/api
Length of output: 171
🏁 Script executed:
Repository: openshift/api
Length of output: 88
🏁 Script executed:
Repository: openshift/api
Length of output: 1704
🏁 Script executed:
Repository: openshift/api
Length of output: 986
🏁 Script executed:
# Check git status - is this file modified locally? git status Dockerfile.ocpRepository: openshift/api
Length of output: 122
🏁 Script executed:
Repository: openshift/api
Length of output: 73
🏁 Script executed:
Repository: openshift/api
Length of output: 916
🏁 Script executed:
# Show the commit message and details git show --stat c63fe74aRepository: openshift/api
Length of output: 346
🏁 Script executed:
Repository: openshift/api
Length of output: 916
Base image uses personal Quay.io registry instead of official OpenShift registry.
The builder base image has been changed from the official OpenShift registry (
registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22) to a personal Quay.io repository (quay.io/jacobsee/openshift-build:rhel-9-golang-1.25). This introduces critical risks:Revert the builder stage to use the official OpenShift registry before merging.
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
Learn more
(IaC/Dockerfile)
🤖 Prompt for AI Agents