Open
Conversation
127abe7 to
c3ad95d
Compare
Contributor
Author
|
@DeepDiver1975 @jvillafanez this works for activity, admin_audit and impersonate apps. Please review. Specially for security loopholes... And I think that we could merge and use this, and then I can expand its features/options next week to cover more of the "special" apps (things that send email, LDAP, files_primary_s3....). Let me know which "external feature" apps are most important to support first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the "basic" flow that sets up Apache, installs a single or dual-server environment with 1 or 2 owncloud core instances running with the app-under-test set up and enabled. That allows ordinary tests and federated tests to run and pass.
I have tried to pass things in env variables etc, in the same way as was done in the other PRs today that secure the flow from command injection, validate inputs... That will need reviewing to find any holes that I have missed.
In future (next week), the acceptance reusable workflow will need to be enhanced for apps that use more external environment. For example: