AB#117017 Sanitize session URL by removing sensitive query parameters…#21
Open
sebastianchristopher wants to merge 1 commit intomasterfrom
Open
AB#117017 Sanitize session URL by removing sensitive query parameters…#21sebastianchristopher wants to merge 1 commit intomasterfrom
sebastianchristopher wants to merge 1 commit intomasterfrom
Conversation
… in `login` function.
sebastianchristopher
requested review from
buckett,
Copilot,
lardo-de-arnaud and
nicholaswilson100
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Playwright deployment test utilities to prevent sensitive query parameters from appearing in session URLs used during the LTI login flow, reducing the risk of leaking secrets in publicly hosted test artifacts/reports.
Changes:
- Refactors
loginto useasync/awaitinstead of chained promises. - Parses
json.session_urlas aURLand attempts to remove sensitive query parameters before navigation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+29
to
+36
| const sessionUrl = new URL(json.session_url) | ||
|
|
||
| // remove anything sensitive before using it for navigation/logging | ||
| sessionUrl.searchParams.delete('session_token') | ||
| sessionUrl.searchParams.delete('token') | ||
| sessionUrl.searchParams.delete('code') | ||
|
|
||
| await page.goto(sessionUrl.toString()) |
Comment on lines
+21
to
+30
| const response = await request.get(`${host}/login/session_token`, { | ||
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${token}`, | ||
| }, | ||
| }) | ||
|
|
||
| const json = await response.json() | ||
| const sessionUrl = new URL(json.session_url) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… in
loginfunction.This is important if we ever move to publicly hosted deployment test reports