Conversation
Add two safeguards to prevent Electron crashes when opening projects with many large or binary files: 1. Content-based binary detection: check first 8KB for null bytes (same heuristic as git/grep) to skip binary files that lack a recognized extension. Previously only extension-based detection was used, missing extensionless binary files entirely. 2. Configurable cache size limit (default 1GB via maxFileCacheSizeMB preference): stops indexing and shows a warning toast when the limit is reached, disabling Find in Files for that project. The V8 heap limit is ~4GB per process and the web worker has its own heap, so 1GB leaves safe headroom.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two safeguards to prevent Electron crashes when opening projects with many large or binary files:
Content-based binary detection: check first 8KB for null bytes (same heuristic as git/grep) to skip binary files that lack a recognized extension. Previously only extension-based detection was used, missing extensionless binary files entirely.
Configurable cache size limit (default 1GB via maxFileCacheSizeMB preference): stops indexing and shows a warning toast when the limit is reached, disabling Find in Files for that project. The V8 heap limit is ~4GB per process and the web worker has its own heap, so 1GB leaves safe headroom.