license-update: update website with new license info#1762
license-update: update website with new license info#1762ramsey wants to merge 4 commits intophp:masterfrom
Conversation
ramsey
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
|
🚀 Preview for commit 2c14ed2 can be found at https://web-php-pr-1762.preview.thephp.foundation |
|
🚀 Regression report for commit 2c14ed2 is at https://web-php-regression-report-pr-1762.preview.thephp.foundation |
| This ensures that the license information can be read properly even when a | ||
| binary is shipped instead of source code. A text file containing license and | ||
| copyright information is sometimes given the filename "Notice" or "NOTICE," | ||
| and may be referred to as a "notice file." |
There was a problem hiding this comment.
nit: The , in "NOTICE," and the . in "notice file." should be outside the "'s
There was a problem hiding this comment.
Those silly American style guides! 😉
I generally follow the MLA style guide in writing, but the APA style guide and AP stylebook also agree that commas and periods should be placed inside closing quotation marks.
However, I'm aware that British English generally places them outside closing quotation marks. Is it the style of php.net to follow the British style?
ramsey
force-pushed
the
php-license-update
branch
from
f42e1f4 to
e6d8db9
Compare
ramsey
force-pushed
the
php-license-update
branch
from
e6d8db9 to
7b6ff0d
Compare
ramsey
force-pushed
the
php-license-update
branch
from
7b6ff0d to
7a1b921
Compare
|
|
||
| 3. The name "PHP" must not be used to endorse or promote products | ||
| derived from this software without prior permission from the | ||
| PHP Group. This does not apply to add-on libraries or tools |
There was a problem hiding this comment.
can we leave the whitespace changes to a separate PR (if needed at all)?
There was a problem hiding this comment.
actually, can all of the cleanup of the old licenses (commas, removal of "very", etc.) be done separate from the changes to add the new license?
There was a problem hiding this comment.
I've removed the whitespace changes and other clean-up from the older license files.
ramsey
force-pushed
the
php-license-update
branch
from
7a1b921 to
643d4d9
Compare
| <ul> | ||
| <li>GPL or LGPL licensed code cannot be used as a basis for any derived work contributed to PHP.</li> | ||
| <li>Extensions which link GPL'd libraries will not be accepted.</li> | ||
| <li>Extensions which link to LGPL libraries will be strongly discouraged.</li> |
There was a problem hiding this comment.
the LGPL library entry was removed - was this intentional?
also there are still whitespace changes that make things harder to review, e.g. the paragraphs above got indented more
There was a problem hiding this comment.
These changes are intentional. There's no legal reason code within the PHP source cannot link against the LGPL, and we shouldn't be in the business of discouraging people from using LGPL.
Here's a list (probably not exhaustive) of extensions currently in php-src that link against LGPL code (and, in some cases, bundle LGPL code within php-src):
- bcmath--we bundle libbcmath (LGPL) within php-src
- enchant
- gettext
- gmp
- iconv
- mbstring--we bundle libmbfl (LGPL) within php-src
Special mention:
readline links against the readline library, which is licensed under the GPL. However, you can also tell it to use libedit, which is BSD-licensed.
There was a problem hiding this comment.
I can try to refactor this to minimize whitespace differences, but it'll be a while.
4 participants
This PR encompasses the changes proposed in the PHP License Update RFC, for the PHP website.
Discussion is available on the internals mailing list.
Changes proposed for php-src are available at php/php-src#20904.