Skip to content

[Draft] POC: Component migration approach using Tooltip#4069

Open
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:Draft-Component-migration-approach-using-Tooltip
Open

[Draft] POC: Component migration approach using Tooltip#4069
Jatin24062005 wants to merge 1 commit intoprocessing:developfrom
Jatin24062005:Draft-Component-migration-approach-using-Tooltip

Conversation

@Jatin24062005
Copy link
Copy Markdown
Contributor

Issue:

#3965
Following up on the above mentioned discussion.

This is a small POC to demonstrate the migration approach using a single component (CopyableInput), to reduce cognitive load during review.

Included:

  • Add a new Test Coverage
  • Component structure (types, styles, storybook)
  • Example of how CopyableInput children structure could look
  • Following the "one component per PR" approach suggested

This should help make the discussion more concrete and easier to review visually.

Happy to adjust the approach based on feedback from @clairep94.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

@Jatin24062005
Copy link
Copy Markdown
Contributor Author

The test runner (cmd : npm run test) is currently broken in this repo. This has been raised separately and a fix is in progress in #3986. All tests in this PR have been verified locally and pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant