Adapt to deprecation of generic np.timedelta64 dtype#11281
Open
spencerkclark wants to merge 7 commits intopydata:mainfrom
Open
Adapt to deprecation of generic np.timedelta64 dtype#11281spencerkclark wants to merge 7 commits intopydata:mainfrom
np.timedelta64 dtype#11281spencerkclark wants to merge 7 commits intopydata:mainfrom
Conversation
6bcf381 to
6acd92f
Compare
NAT_TYPES and silence deprecation warningtimedelta64 dtype
3 tasks
Collaborator
|
looks good to me. If you're up for it, the same warning is also raised in |
timedelta64 dtypenp.timedelta64 dtype
124717c to
799941c
Compare
4388b5e to
c33f80f
Compare
Member
Author
|
Oops thanks @keewis for noting those additional related failures I missed. This should be good for another look. |
dcherian
approved these changes
Apr 6, 2026
keewis
reviewed
Apr 6, 2026
c3fe02c to
624df92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the few places we relied on a generic
np.timedelta64dtype to explicitly specify the time resolution:NAT_TYPESand relies instead on checking thedtype.kindincomputation.nanops._maybe_null_out.unitusingnp.datetime_datafrom the inputdtypeto determine theuniton the returnedfill_valueincore.dtypes.maybe_promote.np.timedelta64ornp.datetime64object for use downstream inplot.utils._determine_cmap_params.