gh-148222 Fix Null dereference bugs at genericaliasobject.c#148226
Open
prakashsellathurai wants to merge 6 commits intopython:mainfrom
Open
gh-148222 Fix Null dereference bugs at genericaliasobject.c#148226prakashsellathurai wants to merge 6 commits intopython:mainfrom
prakashsellathurai wants to merge 6 commits intopython:mainfrom
Conversation
| if (_PyTuple_Resize(¶meters, len) < 0) { | ||
| Py_DECREF(subparams); | ||
| Py_DECREF(parameters); | ||
| Py_XDECREF(parameters); |
Member
There was a problem hiding this comment.
Apparently _PyTuple_Resize sets its arg to NULL on failures, so this will never be non-NULL. Possibly the only safe way to use _PyTuple_Resize is to keep another pointer to the tuple around and DECREF that on failure? I haven't verified in the code though.
Member
There was a problem hiding this comment.
Simply remove this line.
| { | ||
| gaobject *alias = (gaobject *) self; | ||
| PyObject *obj = PyVectorcall_Function(alias->origin)(alias->origin, args, nargsf, kwnames); | ||
| vectorcallfunc origin_vectorcall = PyVectorcall_Function(alias->origin); |
Member
There was a problem hiding this comment.
The docs say this is primarily useful for checking whether a callable supports vectorcall. Why don't we unconditionally call PyObject_Vectorcall, which automatically falls back to non-vectorcall if needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.