gh-148235: remove duplicate uops _LOAD_CONST_UNDER_INLINE(_BORROW) in JIT#148236
Merged
Fidget-Spinner merged 3 commits intopython:mainfrom Apr 8, 2026
Merged
gh-148235: remove duplicate uops _LOAD_CONST_UNDER_INLINE(_BORROW) in JIT#148236Fidget-Spinner merged 3 commits intopython:mainfrom
_LOAD_CONST_UNDER_INLINE(_BORROW) in JIT#148236Fidget-Spinner merged 3 commits intopython:mainfrom
Conversation
NekoAsakura
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
Member
|
Sorry but I'd rather remove LOAD_CONST_UNDER_INLINE_X as the INSERT_X is clearer. Also the tests changes need fixing, thanks! In the longer-term we should change INSERT_X... to LOAD_CONST_INLINE, SWAP X |
NekoAsakura
changed the title
_INSERT_1_LOAD_CONST_INLINE(_BORROW) in JIT_LOAD_CONST_UNDER_INLINE(_BORROW) in JIT
Contributor
Author
|
Done :) |
| uops = get_opnames(ex) | ||
| self.assertNotIn("_UNARY_INVERT", uops) | ||
| self.assertIn("_INSERT_1_LOAD_CONST_INLINE_BORROW", uops) | ||
| self.assertIn("_LOAD_CONST_INLINE_BORROW", uops) |
Contributor
Author
There was a problem hiding this comment.
_INSERT_1_LOAD_CONST_INLINE_BORROW has no op_without_push entry on main, therefore not simplified away by remove_unneeded_uops.
| self.assertIsNotNone(ex) | ||
| uops = get_opnames(ex) | ||
| self.assertNotIn("_REPLACE_WITH_TRUE", uops) | ||
| self.assertIn("_INSERT_1_LOAD_CONST_INLINE_BORROW", uops) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_LOAD_CONST_UNDER_INLINE(_BORROW)in JIT #148235