allow white logos for pypi footer by JacobCoffee · Pull Request #2979 · python/pythondotorg

JacobCoffee · 2026-04-06T18:16:25Z

Description

Allow setting white logo for dark footers like PyPI footer

Copilot

Pull request overview

Adds support for an optional “white logo” asset so sponsor logos can be displayed appropriately on dark backgrounds (e.g., the PyPI footer).

Changes:

Add white_logo ImageField to Sponsor with migration support.
Accept and persist white_logo via sponsorship application and sponsor update forms.
Expose white_logo via the logo placements API and display it in the Sponsorship admin view.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
apps/sponsors/serializers.py	Extends logo placement serializer to include `white_logo` URL.
apps/sponsors/models/sponsors.py	Adds optional `white_logo` image field to Sponsor model.
apps/sponsors/migrations/0104_add_sponsor_white_logo.py	Schema migration adding the `white_logo` column.
apps/sponsors/forms.py	Adds `white_logo` upload field and saves it on sponsor creation/update.
apps/sponsors/api.py	Includes `white_logo` URL (or null) in logo placement API response.
apps/sponsors/admin.py	Adds admin display method for sponsor white logo thumbnail on Sponsorship admin.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

apps/sponsors/api.py

apps/sponsors/forms.py

apps/sponsors/admin.py

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 77dff453c6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

apps/sponsors/forms.py

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

apps/users/templates/users/sponsor_info_update.html:250

Same spacing issue as above: when print_logo is present, the “Currently” link and the help text are adjacent with no line break/block separation, which can make the UI hard to read. Add a   before the helptext (or wrap “Currently” in its own block element).

          <br/>Currently: <a href="{{ sponsor.print_logo.url }}">{{ sponsor.print_logo.name }}</a>
        {% endif %}
        {% if form.print_logo.help_text %}
          <span class="helptext">{{ form.print_logo.help_text }}</span>
        {% endif %}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-07T16:53:51Z

apps/users/templates/users/sponsor_info_update.html

+          <br/>Currently: <a href="{{ sponsor.web_logo.url }}">{{ sponsor.web_logo.name }}</a>
        {% endif %}
        {% if form.web_logo.help_text %}
          <span class="helptext">{{ form.web_logo.help_text }}</span>
        {% endif %}


Currently: is rendered inline via  Currently: ... and then the help text … follows without a line break or block wrapper. This will cause the help text to run together with the “Currently” link on the same line. Consider adding a   before the helptext (or wrapping the “Currently” link in its own block element) for consistent spacing.

Copilot · 2026-04-07T16:53:52Z

apps/users/templates/users/sponsor_info_update.html

+          <br/>Currently: <a href="{{ sponsor.white_logo.url }}">{{ sponsor.white_logo.name }}</a>
+        {% endif %}
+        {% if form.white_logo.help_text %}
+          <span class="helptext">{{ form.white_logo.help_text }}</span>
+        {% endif %}


Same spacing issue as web_logo: the “Currently” link and the help text are rendered back-to-back without a line break, so the help text will appear immediately after the link. Add a   before the helptext (or wrap “Currently” in its own block element).

Copilot · 2026-04-07T16:53:52Z

apps/users/templates/users/sponsor_info_update.html

+      <p class="form_field">
+        <label>{{ form.landing_page_url.label }} <span class="error-message">{% if form.landing_page_url.errors %}
+          {{ form.landing_page_url.errors.as_text }}</span>{% endif %}</label>
+        <span
+            class="helptext">Landing page URL. The linked page may not contain any sales or marketing information.</span>
+        {% render_field form.landing_page_url %}
+      </p>


This template refactors several fields from being inside .inline_fields wrappers to standalone  blocks (e.g., landing page / Twitter / LinkedIn). That changes the layout behavior tied to the .inline_fields CSS rules in static/css/style.css:3485-3493 (inline-block 49% columns). If the layout change isn’t intended as part of “allow white logos”, consider reverting/splitting these markup changes or adjusting the grouping so the original 2-column layout is preserved.

Copilot · 2026-04-07T16:53:52Z

apps/sponsors/templates/sponsors/new_sponsorship_application_form.html

+        <p class="form_field">
          <label>{{ form.web_logo.label }} <span class="error-message">{% if form.web_logo.errors %}{{ form.web_logo.errors.as_text }}</span>{% endif %}</label>
-            {% render_field form.web_logo %}
-            {% if sponsor.web_logo %}
-          <p>Currently: <a href="{{ sponsor.web_logo.url }}">{{ sponsor.web_logo.name }}</a></p>
-        {% endif %}
-            {% if form.web_logo.help_text %}
-            <br/>
-            <span class="helptext">{{ form.web_logo.help_text }}</span>
-            {% endif %}
-          </p>
-          </div>
+          {% render_field form.web_logo %}
+          {% if sponsor.web_logo %}
+          <br/>Currently: <a href="{{ sponsor.web_logo.url }}">{{ sponsor.web_logo.name }}</a>
+          {% endif %}
+          {% if form.web_logo.help_text %}
+          <br/>
+          <span class="helptext">{{ form.web_logo.help_text }}</span>
+          {% endif %}
+        </p>


The .inline_fields wrapper around the logo upload fields was removed, which will change the 2-column layout controlled by static/css/style.css:3485-3493. With the new white_logo field, consider regrouping the logo inputs into one or more .inline_fields sections (e.g., web_logo + white_logo side-by-side, print_logo below) so the layout remains consistent with existing styling.

Copilot · 2026-04-07T16:53:53Z

apps/sponsors/templates/sponsors/new_sponsorship_application_form.html

+        <p class="form_field">
+          <label>{{ form.landing_page_url.label }} <span class="error-message">{% if form.landing_page_url.errors %}{{ form.landing_page_url.errors.as_text }}</span>{% endif %}</label>
+          {% render_field form.landing_page_url %}
+          {% if form.landing_page_url.help_text %}
+          <br/>
+          <span class="helptext">{{ form.landing_page_url.help_text }}</span>
+          {% endif %}
+        </p>

-          <div>
-            <p class="form_field">
-              <label>{{ form.twitter_handle.label }} <span class="error-message">{% if form.twitter_handle.errors %}{{ form.twitter_handle.errors.as_text }}</span>{% endif %}</label>
-              {% render_field form.twitter_handle %}
-              {% if form.twitter_handle.help_text %}
-              <br/>
-              <span class="helptext">{{ form.twitter_handle.help_text }}</span>
-              {% endif %}
-            </p>
-          </div>
+        <p class="form_field">
+          <label>{{ form.twitter_handle.label }} <span class="error-message">{% if form.twitter_handle.errors %}{{ form.twitter_handle.errors.as_text }}</span>{% endif %}</label>
+          {% render_field form.twitter_handle %}
+          {% if form.twitter_handle.help_text %}
+          <br/>
+          <span class="helptext">{{ form.twitter_handle.help_text }}</span>
+          {% endif %}
+        </p>


This template also removes an .inline_fields grouping for the landing page / Twitter / LinkedIn fields. Since .inline_fields has specific 2-column styling (static/css/style.css:3485-3493), please confirm the layout change is intentional; otherwise, restore the wrapper or adjust the grouping to keep the intended column layout.

allow white logos for pypi footer

77dff45

Copilot AI review requested due to automatic review settings April 6, 2026 18:16

Copilot started reviewing on behalf of JacobCoffee April 6, 2026 18:17 View session

allow sponsors to self-serve this

8b5685e

Copilot AI reviewed Apr 6, 2026

View reviewed changes

apps/sponsors/api.py Show resolved Hide resolved

apps/sponsors/forms.py Show resolved Hide resolved

apps/sponsors/admin.py Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Apr 6, 2026

View reviewed changes

apps/sponsors/forms.py Show resolved Hide resolved

apps/sponsors/forms.py Show resolved Hide resolved

JacobCoffee mentioned this pull request Apr 6, 2026

Use Sponsor Logos pypi/warehouse#19803

Open

JacobCoffee and others added 2 commits April 6, 2026 15:01

test: add API tests for white_logo field

e38e3eb

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

de-stagger form fields

d3fef5e

Copilot AI review requested due to automatic review settings April 7, 2026 16:48

Copilot started reviewing on behalf of JacobCoffee April 7, 2026 16:49 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

JacobCoffee merged commit de5afa0 into main Apr 7, 2026
18 checks passed

JacobCoffee deleted the white-logos branch April 7, 2026 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

allow white logos for pypi footer#2979

allow white logos for pypi footer#2979
JacobCoffee merged 4 commits intomainfrom
white-logos

JacobCoffee commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Copilot AI Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

JacobCoffee commented Apr 6, 2026

Description

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants