Skip to content

Arm backend: Do not skip _fuse_duplicate_users pass#19017

Merged
mansnils merged 1 commit intopytorch:mainfrom
mansnils:vgf
Apr 22, 2026
Merged

Arm backend: Do not skip _fuse_duplicate_users pass#19017
mansnils merged 1 commit intopytorch:mainfrom
mansnils:vgf

Conversation

@mansnils
Copy link
Copy Markdown
Collaborator

@mansnils mansnils commented Apr 21, 2026

Removes previous workaround of skipping a pass for VGF backend, as the actual root cause (GRPHCOMP-3140) has been resolved.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell

Removes previous workaround of skipping a pass for VGF backend, as the
actual root cause (GRPHCOMP-3140) has been resolved.

Signed-off-by: Måns Nilsson <mans.nilsson@arm.com>
Change-Id: If56f77f2f24977014d892c9980c9be4ae1340d60
Copilot AI review requested due to automatic review settings April 21, 2026 12:15
@mansnils mansnils requested a review from digantdesai as a code owner April 21, 2026 12:15
@mansnils mansnils added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Apr 21, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 21, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19017

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (6 Unrelated Failures)

As of commit 48bb74c with merge base e281726 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 21, 2026
@github-actions github-actions Bot added the module: arm Issues related to arm backend label Apr 21, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a VGF-specific workaround that disabled the _fuse_duplicate_users pass in the Arm backend, now that the underlying issue (GRPHCOMP-3140) is resolved.

Changes:

  • Removes the VgfCompileSpec override that disabled fuse_duplicate_users in the default pass pipeline config.
  • Adds a unit test asserting that VGF’s default pass pipeline config enables fuse_duplicate_users.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
backends/arm/vgf/compile_spec.py Stops overriding default pipeline config to disable fuse_duplicate_users, restoring base defaults.
backends/arm/test/misc/test_compile_spec.py Adds coverage to ensure VGF defaults to FuseDuplicateUsersConfig.ENABLED.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mansnils mansnils merged commit 63217d2 into pytorch:main Apr 22, 2026
439 of 454 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants