Arm backend: Do not skip _fuse_duplicate_users pass#19017
Arm backend: Do not skip _fuse_duplicate_users pass#19017mansnils merged 1 commit intopytorch:mainfrom
Conversation
Removes previous workaround of skipping a pass for VGF backend, as the actual root cause (GRPHCOMP-3140) has been resolved. Signed-off-by: Måns Nilsson <mans.nilsson@arm.com> Change-Id: If56f77f2f24977014d892c9980c9be4ae1340d60
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19017
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (6 Unrelated Failures)As of commit 48bb74c with merge base e281726 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Pull request overview
This PR removes a VGF-specific workaround that disabled the _fuse_duplicate_users pass in the Arm backend, now that the underlying issue (GRPHCOMP-3140) is resolved.
Changes:
- Removes the
VgfCompileSpecoverride that disabledfuse_duplicate_usersin the default pass pipeline config. - Adds a unit test asserting that VGF’s default pass pipeline config enables
fuse_duplicate_users.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
backends/arm/vgf/compile_spec.py |
Stops overriding default pipeline config to disable fuse_duplicate_users, restoring base defaults. |
backends/arm/test/misc/test_compile_spec.py |
Adds coverage to ensure VGF defaults to FuseDuplicateUsersConfig.ENABLED. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Removes previous workaround of skipping a pass for VGF backend, as the actual root cause (GRPHCOMP-3140) has been resolved.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @Sebastian-Larsson @robell