Skip to content

Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031) #19031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ocvh wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −7
Open

Switch VGF backend from custom vulkan-headers-1.4.343 to standardized khronos (#19031) #19031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backends/arm/runtime/VGFBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
* Copyright 2025-2026 Arm Limited and/or its affiliates.
*
Expand Down Expand Up @@ -27,8 +27,8 @@
using executorch::runtime::Result;
using executorch::runtime::Span;

// We use the platform and runtime environment provided by the Vulkan delegate
#include <executorch/backends/vulkan/runtime/vk_api/vk_api.h>
// Volk meta-loader provides Vulkan function pointers (ARM tensor extensions, etc.)
#include <volk.h>

// Dependencies for processing VGF files into Vulkan calls
#include <vgf/decoder.hpp>
Expand Down
4 changes: 2 additions & 2 deletions backends/arm/runtime/VGFSetup.h
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
/*
* Copyright 2025-2026 Arm Limited and/or its affiliates.
*
Expand All @@ -15,8 +15,8 @@
using executorch::runtime::ArrayRef;
using executorch::runtime::CompileSpec;

// We use the platform and runtime environment provided by the Vulkan delegate
#include <executorch/backends/vulkan/runtime/vk_api/vk_api.h>
// Volk meta-loader provides Vulkan function pointers (ARM tensor extensions, etc.)
#include <volk.h>

namespace executorch {
namespace backends {
Expand Down
6 changes: 3 additions & 3 deletions backends/arm/runtime/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def define_common_targets():
# function-pointer variables live in the same linkage unit.
# Linking from a separate static library causes the linker to
# drop the symbols when building a shared library.
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:volk_arm_src",
"fbsource//third-party/volk:volk_src",
],
exported_headers = ["VGFSetup.h"],
# @lint-ignore BUCKLINT: Avoid `link_whole=True` (https://fburl.com/avoid-link-whole)
Expand All @@ -60,7 +60,7 @@ def define_common_targets():
"//executorch/runtime/backend:interface",
"//executorch/runtime/core:core",
"fbsource//third-party/arm-vgf-library/v0.9.0/src:vgf",
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:volk_arm",
"fbsource//third-party/vulkan-headers-1.4.343/v1.4.343/src:vulkan-headers",
"fbsource//third-party/volk:volk-header",
"fbsource//third-party/khronos:vulkan-headers",
],
)
Loading