Skip to content

Use EValue::tryTo* #19040

Open
lucylq wants to merge 3 commits intogh/lucylq/151/headfrom
gh/lucylq/152/head
Open

Use EValue::tryTo* #19040
lucylq wants to merge 3 commits intogh/lucylq/151/headfrom
gh/lucylq/152/head

Conversation

@lucylq
Copy link
Copy Markdown
Contributor

@lucylq lucylq commented Apr 22, 2026

Use tryTo in:

  • parseTensorList (tensor_parser_exec_aten.cpp) — called .toTensor()
    on each element index of a TensorList.
  • parseListOptionalType (tensor_parser.h) — called .toOptional()
    on each element index of an OptionalTensorList.
  • FreeCall instruction handler (method.cpp) — called .toTensor()
    on the value index being freed.

Unit tests cover parseTensorList and parseListOptionalType receiving
a non-matching EValue and expect Error::InvalidType.

Authored-with: Claude

[ghstack-poisoned]
@lucylq
Copy link
Copy Markdown
Contributor Author

lucylq commented Apr 22, 2026

@lucylq lucylq requested a review from JacobSzwejbka as a code owner April 22, 2026 00:15
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 22, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19040

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures, 1 Pending

As of commit 36e811f with merge base 273888f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2026
@lucylq lucylq changed the title Use EValue::tryTo* to fix TOB-EXECUTORCH-6/7/8 Use EValue::tryTo* Apr 22, 2026
Github Executorch added 2 commits April 21, 2026 18:52
[ghstack-poisoned]
[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant