PENDING: arm64: dts: qcom: monaco-evk: fix overlay stacking and PHY reset polarity#994
Open
ayaan-anwar wants to merge 1 commit intoqualcomm-linux:tech/overlay/dtfrom
Open
Conversation
…eset polarity Fix issues with the Monaco EVK IFP Mezz staging overlay for QPS615: 1) Setting the VendorDtbOverlays EFI variable to "staging" causes UEFI to fail the overlay application entirely. The staging overlay references &eeprom1, a label introduced by the ifp-mezzanine overlay. When overlays are stacked, ufdt does not propagate __symbols__ from previously applied overlays into the working DTB, so &eeprom1 cannot be resolved as a fixup target and the firmware aborts with FDT_ERR_NOTFOUND. Fix this by defining the eeprom node inline under &i2c15, which is present in the base DTB __symbols__. 2) The QCA8081 port does not come out of reset and is therefore never detected. The PHY reset line is declared GPIO_ACTIVE_HIGH, but the QCA8081 has an active-low reset input. With GPIO_ACTIVE_HIGH the driver's deassert call maps logical 0 to physical LOW, holding RESETN asserted throughout probe. Correct it to GPIO_ACTIVE_LOW. Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issues with the Monaco EVK IFP Mezz staging overlay for QPS615:
Setting the VendorDtbOverlays EFI variable to "staging" causes UEFI
to fail the overlay application entirely. The staging overlay
references &eeprom1, a label introduced by the ifp-mezzanine
overlay. When overlays are stacked, ufdt does not propagate
symbols from previously applied overlays into the working DTB,
so &eeprom1 cannot be resolved as a fixup target and the firmware
aborts with FDT_ERR_NOTFOUND. Fix this by defining the eeprom node
inline under &i2c15, which is present in the base DTB symbols.
The QCA8081 port does not come out of reset and is therefore never
detected. The PHY reset line is declared GPIO_ACTIVE_HIGH, but the
QCA8081 has an active-low reset input. With GPIO_ACTIVE_HIGH the
driver's deassert call maps logical 0 to physical LOW, holding
RESETN asserted throughout probe. Correct it to GPIO_ACTIVE_LOW.
CRs-Fixed: 4510876