make Audio_Record_Playback more deterministic for offline CI by smuppand · Pull Request #411 · qualcomm-linux/qcom-linux-testkit

smuppand · 2026-04-19T12:48:04Z

Improve Audio_Record_Playback stability and result reporting for CI runs. Enhancements to address as part of #408

This update keeps backward compatibility for user-provided clip sources, but makes the default path more reliable by preferring locally generated OGG/MP3 sample clips when no clip path or clip URL is explicitly requested.

It also tightens result handling for dependent pulsesrc playback cases. When running in all mode, playback_pulsesrc_wav and playback_pulsesrc_flac now fail if the corresponding pulsesrc recording
in the same run did not produce a valid file, instead of being marked as skip. This makes the final summary reflect the actual end-to-end failure more accurately.

Changes included:

prefer offline-generated OGG/MP3 clips for default CI flow
preserve existing --clip-path / --clip-url behavior for backward compatibility
track whether external clips were explicitly requested
pass explicit provisioning context from run.sh into provisioning helper
mark dependent pulsesrc playback cases as FAIL in all mode when the
prerequisite recording failed in the same run

Why:

reduce network dependency in CI
avoid misleading SKIP results for same-run prerequisite failures
make overlay/base comparisons easier by producing clearer verdicts

Lava jobs for reference with these code changes.
Base/ Config 1 - https://lava.infra.foundries.io/scheduler/job/183417

smuppand · 2026-04-19T12:48:28Z

@nitinn22 to review

nitinn22 · 2026-04-19T17:19:11Z

Main suggestions are around avoiding silent copy failures and improving portability/robustness of the generation pipelines (audioresample, encoder property compatibility). Also, if a LAVA job can be posted with these encode followed by decode and full suite working fine would be perfect.

nitinn22 · 2026-04-21T00:31:07Z

+  sample_ogg="$outdir/sample_audio.ogg"
+  sample_mp3="$outdir/sample_audio.mp3"
+
+  have_ogg=0


have_ogg are global state shared across helper functions. This is fine in POSIX sh, but a short comment noting this dependency would help future readers.

nitinn22 · 2026-04-21T00:34:07Z

I guess we are good post these minor fixes, pls share a working LAVA job.

smuppand · 2026-04-21T01:14:49Z

I guess we are good post these minor fixes,

Agreed. I added a short comment documenting that have_ogg / have_mp3 are intentionally shared global availability flags in this POSIX sh flow, refreshed by audio_record_mark_existing_samples() and consumed by subsequent provisioning stages.

pls share a working LAVA job.

https://lava.infra.foundries.io/scheduler/job/184344

nitinn22

LGTM

… overrides Update audio clip provisioning to prefer locally generated GStreamer sample clips for OGG and MP3 when no external clip source is explicitly requested, making CI runs less dependent on network availability. This keeps backward compatibility by preserving existing --clip-path, --clip-url, AUDIO_CLIP_PATH, and AUDIO_CLIP_URL behavior. The run.sh changes now track whether an external source was explicitly requested and pass that state into provision_test_files(), while the provisioning logic can still fall back to user-provided clips or downloads when requested. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

encoders in gstreamer_build_audio_record_pipeline(). This makes pulsesrc-based recording paths, especially FLAC, more robust across platforms by improving caps/rate negotiation before encoding and reducing intermittent file-generation failures seen in CI/LAVA runs. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>

smuppand · 2026-04-21T04:21:23Z

LGTM

Made minor changes, sometimes still we are observing the
run_record_test() uses duration + 10
playback uses duration + 10
local OGG/MP3 generation uses duration + 10
but run_record_pulsesrc_test() uses only duration
https://lava.infra.foundries.io/scheduler/job/184431#L2529

[INFO] 1970-01-01 00:00:56 - Record exit code: 124
[FAIL] 1970-01-01 00:00:56 - record_pulsesrc_flac: FAIL (no output file created)

[INFO] 1970-01-01 00:01:27 - ==========================================
[FAIL] 1970-01-01 00:01:27 - playback_pulsesrc_flac: FAIL - recorded file too small: 0 bytes (pulsesrc recording failed in same run)
[INFO] 1970-01-01 00:01:27 - Playing back Test files (OGG/MP3)...
[INFO] 1970-01-01 00:01:27 - ==========================================

After adjusting the duration, the two instances below are now passing.
https://lava.infra.foundries.io/scheduler/job/184389#L2558
https://lava.infra.foundries.io/scheduler/job/184390#L2531

nitinn22

LGTM

bhargav0610

LGTM

smuppand requested review from Vkenjam and bhargav0610 April 19, 2026 12:48