[backport] Fix Dart Sass failing in enterprise Windows with Group Policy restrictions#14369
Merged
[backport] Fix Dart Sass failing in enterprise Windows with Group Policy restrictions#14369
Conversation
Enterprise Windows environments with Group Policy / AppLocker rules that block .bat execution from %TEMP% cause the safeWindowsExec temp wrapper to fail, breaking dart-sass invocation (regression from #14002). Try safeWindowsExec first (handles spaces in paths), then fall back to direct execProcess call (v1.8 behavior) when it fails. Fixes #14367
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
v1.9-specific fix for #14367. The full fix (bypassing
sass.batentirely) is in v1.10 via #14273.In v1.9, #14002 routed
sass.batthrough asafeWindowsExectemp.batwrapper to handle path quoting with spaces. On enterprise Windows systems where Group Policy / AppLocker blocks.batexecution from%TEMP%, this breaks dart-sass invocation — a regression from v1.8 wheresass.batwas called directly from the trusted install directory.When
safeWindowsExecfails, Quarto now falls back to directsass.batexecution (v1.8 behavior), restoring functionality in locked-down environments.Fixes #14367