Conversation
A few things going on here: - Implying Jamil as 2IC in all crates except `bitreq`. - Leaving RCassatta and apoelstra at the head of the list for their respective crates out of respect but Jamil and I are doing the maintenance work [0]. - Add `integration_test` and `verify` for completeness. Note `bitreq` lists owners who are doing reviews but I'm still responsible for the doing the merging and releasing. We need an additional owner on crates.io for `bitreq` because of bus factor. For `bitcoind` and `electrsd` RCasatta has already ack'd this in public on rust-bitcoin#542. For `jsonrpc` this PR needs ack from apoelstra to publicly ack what he told me in private. Onwards and upwards team!
|
cc @apoelstra please ack this to publicly acknowledge that Jamil and I are going to crank on @RCasatta you acked on #542 already. If either of you do not want to be listed in CODEOWNERS just holla. |
|
cc @jamillambert because I'm throwing him in the deep end as 2IC. Is that even a term in open source? I jokingly refer to myself as GregKH in |
|
ACK |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
ACK in general, but Github shows an error:
Unknown owner on line 5: make sure @RCasatta exists and has write access to the repository
Note bitreq lists owners who are doing reviews but I'm still responsible for the doing the merging and releasing. We need an additional owner on crates.io for bitreq because of bus factor.
Feel free to add me to crates.io, cc @TheBlueMatt for visibility in case he's also fine with being added.
@RCasatta now has write perms. Please say if you'd like that not to be the case Riccardo. |
|
@tnull 'tnull' didn't show up in crates.io. I added TheBlueMatt as a crate owner. cc @TheBlueMatt |
Strange, should definitely work: https://crates.io/users/tnull |
4 participants
A few things going on here:
bitreq.integration_testandverifyfor completeness.Note
bitreqlists owners who are doing reviews but I'm still responsible for the doing the merging and releasing. We need an additional owner on crates.io forbitreqbecause of bus factor.For
bitcoindandelectrsdRCasatta has already ack'd this in public on #542. Forjsonrpcthis PR needs ack from apoelstra to publicly ack what he told me in private.Onwards and upwards team!