Open
Conversation
Code copy only to make it easier in the next patch to see what the changes are for async.
Remove code related to fuzzing from the new async files. Fuzzing of the async client can be added back later if needed.
In preparation for adding another async client change the Debug impl to refer to the local sync Client so that there is no conflict when adding the second async Client struct.
satsfy
approved these changes
Apr 17, 2026
|
|
||
| impl BitreqHttpTransport { | ||
| /// Constructs a new [`BitreqHttpTransport`] with default parameters. | ||
| pub fn new() -> Self { BitreqHttpTransport::default() } |
Contributor
There was a problem hiding this comment.
Just a comment. Should we consider some validation here? So that the user cannot shoot themselves on the foot like:
use jsonrpc::bitreq_http_async::Builder;
Builder::new().url("not_a_url").is_ok();I suppose a validation could happen at new or at fn build(self). No change required, because sync client also does it too. But it's a thought for production.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled out of #505 and polished.
The aim is to add async support without breaking existing sync downstream. This includes keeping the reexports of the current sync
Clientat the crate root.