Skip to content

Finalize Release Candidate 1#107

Merged
d2dyno1 merged 96 commits intomasterfrom
f_rc1
Apr 18, 2026
Merged

Finalize Release Candidate 1#107
d2dyno1 merged 96 commits intomasterfrom
f_rc1

Conversation

@d2dyno1
Copy link
Copy Markdown
Member

@d2dyno1 d2dyno1 commented Mar 26, 2026

No description provided.

@d2dyno1 d2dyno1 marked this pull request as ready for review March 26, 2026 20:32
@d2dyno1 d2dyno1 marked this pull request as draft March 26, 2026 20:33
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 248 out of 265 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Platforms/SecureFolderFS.UI/Helpers/BaseLifecycleHelper.cs
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 267 out of 284 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Platforms/SecureFolderFS.Uno/Program.cs
Comment thread src/Shared/SecureFolderFS.SourceGenerator/InjectGenerator.cs Outdated
@d2dyno1
Copy link
Copy Markdown
Member Author

d2dyno1 commented Apr 18, 2026

@copilot Fix the failing CI tests.

Copy link
Copy Markdown

Copilot AI commented Apr 18, 2026

@copilot Fix the failing CI tests.

Fixed in 642e866. I investigated the failing CI run and patched recycle-bin restore to use a safe fallback destination resolution from the recycle-bin item’s original parent path before invoking the folder picker, which removes the failure path seen in Create_FolderWith_SubFile_SubFolder_Delete_And_Restore_NoThrow. I also verified the targeted test passes in both Debug and Release.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • crl.godaddy.com
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/SecureFolderFS/SecureFolderFS/src/Platforms/SecureFolderFS.Uno/SecureFolderFS.Uno.csproj --packages /tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)
  • ocsp.godaddy.com
    • Triggering command: /usr/bin/dotnet dotnet restore --no-dependencies /home/REDACTED/work/SecureFolderFS/SecureFolderFS/src/Platforms/SecureFolderFS.Uno/SecureFolderFS.Uno.csproj --packages /tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/packages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal /p:TargetFrameworkRootPath=/tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/emptyFakeDotnetRoot /p:NetCoreTargetingPackRoot=/tmp/codeql-scratch-d52628fd4f0752cc/dbs/csharp/working/emptyFakeDotnetRoot /p:AllowMissingPrunePackageData=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@d2dyno1 d2dyno1 marked this pull request as ready for review April 18, 2026 17:16
@d2dyno1 d2dyno1 added the approved The pull request has been reviewed and approved label Apr 18, 2026
@d2dyno1 d2dyno1 merged commit 5ddd83a into master Apr 18, 2026
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved The pull request has been reviewed and approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants