You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Base fee is the amount of fees that get burnt for each transaction. We may or may not set it to a non-zero value depending on tokeneconomics. For benchmarking purpose, a zero base fee will allow us gauge a better best-case scenario
❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.14%. Comparing base (9ccd5ca) to head (b99d758). ⚠️ Report is 261 commits behind head on main.
We truly appreciate your contribution and the time you’ve invested in this PR.
Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective.
If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.
We truly appreciate your contribution and the time you’ve invested in this PR.
Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective.
If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Base fee is the amount of fees that get burnt for each transaction. We may or may not set it to a non-zero value depending on tokeneconomics. For benchmarking purpose, a zero base fee will allow us gauge a better best-case scenario
Testing performed to validate your change
BENCHMARK_CONFIG="scripts/scenarios/evm_fast.json" ZERO_BASE_FEE=true GIGA_EXECUTOR=true GIGA_OCC=true scripts/benchmark.sh->26kGIGA_EXECUTOR=true GIGA_OCC=true scripts/benchmark.sh->20k