Open
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3247 +/- ##
==========================================
- Coverage 59.22% 58.98% -0.25%
==========================================
Files 2069 2082 +13
Lines 169661 170572 +911
==========================================
+ Hits 100487 100608 +121
- Misses 60378 61158 +780
- Partials 8796 8806 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
yzang2019
reviewed
Apr 17, 2026
| @@ -0,0 +1,78 @@ | |||
| package blockdb | |||
Contributor
There was a problem hiding this comment.
Recommend move blockDB code to ledger_db/block
Comment on lines
+197
to
+201
| // Periodic prune. | ||
| if blk.Height > b.config.UnprunedBlocks { | ||
| b.metrics.SetMainThreadPhase("prune") | ||
| lowestToKeep := blk.Height - b.config.UnprunedBlocks | ||
| if err := b.db.Prune(b.ctx, lowestToKeep); err != nil { |
Contributor
There was a problem hiding this comment.
The comment says periodic prune, but we are pruning for every block here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a benchmarking framework for the block DB. This benchmark currently exercises the write pathway. The read pathway benchmarking will come in a future PR.