Fix 400 error querying blocks with no transactions#3260
Open
utafrali wants to merge 1 commit intosei-protocol:mainfrom
Open
Fix 400 error querying blocks with no transactions#3260utafrali wants to merge 1 commit intosei-protocol:mainfrom
utafrali wants to merge 1 commit intosei-protocol:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Fixes #3239
The GetBlockWithTxs endpoint was failing when querying an empty block. It was checking if offset >= blockTxsLn without first verifying blockTxsLn > 0, so any request (even offset=0) would error out when there were no transactions.
Added a check for blockTxsLn > 0 before the offset validation. Handles empty blocks correctly now.
Testing performed to validate your change
Tested locally with both empty and non-empty blocks. Empty blocks now work, and offset validation still works for non-empty blocks.