Remove noisy presence compare info log#11
Open
frederickbaier wants to merge 1 commit intofeat/platformfrom
Open
Remove noisy presence compare info log#11frederickbaier wants to merge 1 commit intofeat/platformfrom
frederickbaier wants to merge 1 commit intofeat/platformfrom
Conversation
frederickbaier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The proxy/controller presence reconciliation loop fires
handleCompareRequeston every tick. Each invocation currently logs the controller hash, local hash, match result, and the full online-player list atINFOlevel. On a busy proxy this dominates log output and buries genuinely interesting operational events behind routine traffic.Because the log is purely diagnostic and does not influence the compare/response outcome, removing it restores
INFOas a useful signal level without changing any reconciliation behavior.Changes
LOGGER.info("[Presence] Compare request received …")call (4 lines) fromProxyPresenceResponder.handleCompareRequestType of Change
Behavior Change
Before: Every presence compare request emits an
INFOlog line containing controller hash, local hash, match flag, and the full list of online player names + UUIDs.After: The compare request completes silently on success. Warning-level logging for actual processing failures remains unchanged.
Pre-Deployment Migrations
No migrations required before deploying.