Skip to content

fix(blocks): render tooltip field in sub-block label #4072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minijeong-log wants to merge 12 commits into from
+13 −0
Closed

fix(blocks): render tooltip field in sub-block label #4072

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0b9019d
v0.6.23: MCP fixes, remove local state in favor of server state, moth…
waleedlatif1 Apr 4, 2026
a54dcbe
v0.6.24: copilot feedback wiring, captcha fixes
waleedlatif1 Apr 4, 2026
28af223
v0.6.25: cloudwatch, cloudformation, live kb sync, linear fixes, post…
waleedlatif1 Apr 5, 2026
d889f32
v0.6.26: ui improvements, multiple response blocks, docx previews, ol…
waleedlatif1 Apr 5, 2026
316bc8c
v0.6.27: new triggers, mothership improvements, files archive, queuei…
waleedlatif1 Apr 7, 2026
3f508e4
v0.6.28: new docs, delete confirmation standardization, dagster integ…
waleedlatif1 Apr 7, 2026
d6ec115
v0.6.29: login improvements, posthog telemetry (#4026)
TheodoreSpeaks Apr 7, 2026
d7da35b
v0.6.30: slack trigger enhancements, connectors performance improveme…
waleedlatif1 Apr 8, 2026
cf233bb
v0.6.31: elevenlabs voice, trigger.dev fixes, cloud whitelabeling for…
waleedlatif1 Apr 8, 2026
f8f3758
v0.6.32: BYOK fixes, ui improvements, cloudwatch tools, jsm tools ext…
waleedlatif1 Apr 9, 2026
f21b57b
fix(blocks): render tooltip field in sub-block label
minijeong-log Apr 9, 2026
ee1965d
Merge branch 'simstudioai:main' into fix/sub-block-tooltip-rendering
minijeong-log Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...eId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
Check,
Clipboard,
ExternalLink,
Info,
} from 'lucide-react'
import { useParams } from 'next/navigation'
import { Button, Input, Label, Tooltip } from '@/components/emcn/components'
Expand Down Expand Up @@ -249,6 +250,18 @@ const renderLabel = (
<Label className='flex items-baseline gap-1.5 whitespace-nowrap'>
{config.title}
{required && <span className='ml-0.5'>*</span>}
{config.tooltip && (
<Tooltip.Root>
<Tooltip.Trigger asChild>
<span className='inline-flex'>
<Info className='h-3 w-3 flex-shrink-0 cursor-pointer text-muted-foreground' />
</span>
Comment on lines +255 to +258
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Tooltip trigger is not keyboard-accessible

The <span> wrapping the Info icon has no tabIndex or role, so keyboard-only users cannot reach the tooltip. Radix UI requires a focusable element as the trigger to work correctly with keyboard navigation. Adding tabIndex={0} and role="button" (or swapping for a <button>) would make it accessible.

Suggested change
<Tooltip.Trigger asChild>
<span className='inline-flex'>
<Info className='h-3 w-3 flex-shrink-0 cursor-pointer text-muted-foreground' />
</span>
<span className='inline-flex' tabIndex={0} role='button' aria-label={config.tooltip}>

Note: the existing AlertTriangle tooltip uses the same pattern, so this is a pre-existing gap rather than a regression introduced by this PR.

</Tooltip.Trigger>
<Tooltip.Content side='top'>
<p>{config.tooltip}</p>
</Tooltip.Content>
</Tooltip.Root>
)}
{labelSuffix}
{config.type === 'code' &&
config.language === 'json' &&
Expand Down
Loading