Swap spl-pod for solana-zero-copy + solana-nullable#1069
Open
Swap spl-pod for solana-zero-copy + solana-nullable#1069
Conversation
grod220
commented
Apr 1, 2026
grod220
force-pushed
the
spl-pod-swap
branch
6 times, most recently
from
d655ba0 to
b68f68c
Compare
grod220
commented
Apr 22, 2026
Comment on lines
+43
to
+44
| spl-token-metadata-interface = "1.0.0" | ||
| spl-token-group-interface = "0.7.2" |
Member
Author
There was a problem hiding this comment.
New versions support the new solana-zero-copy/nullable types
grod220
commented
Apr 22, 2026
Comment on lines
+18
to
+19
| [target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies] | ||
| getrandom = { version = "0.2", features = ["js"] } |
Member
Author
There was a problem hiding this comment.
Without this, make build-wasm-interface fails.
the wasm*-unknown-unknown targets are not supported by default, you may need to enable the "js" feature
Turns out spl-pod previously activates getrandom/js transitively. So need to be explicit here now.
grod220
commented
Apr 22, 2026
Comment on lines
+506
to
+507
| #[cfg_attr(feature = "serde", serde(with = "As::<Option<DisplayFromStr>>"))] | ||
| pub authority: MaybeNull<Address>, |
Member
Author
There was a problem hiding this comment.
the serde_with usage here is to preserve the base58 serde encoding that was built into OptionalNonZeroPubkey
grod220
commented
Apr 22, 2026
Comment on lines
-22
to
-25
| arrayref = "0.3.9" | ||
| bytemuck = { version = "1.25.0", features = ["derive"] } | ||
| num-derive = "0.4" | ||
| num-traits = "0.2" |
Member
Author
There was a problem hiding this comment.
While deps/features were being added, used cargo machete to find a collection of unused ones in this program and removed them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rebased after #1090
This PR migrates
token-2022away fromspl-podand ontosolana-zero-copy+solana-nullable. On the road to making the library crates no-std.