docs(examples): drop stale sendOne note from send_sms comment#152
Merged
Palbahngmiyine merged 1 commit intosolapi:betafrom Apr 17, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors error handling and cleans up the codebase. Key changes include the removal of the runSafeSync utility and its tests, the extraction of network retry logic into a helper function in defaultFetcher.ts, and the enhancement of decodeWithBadRequest to provide structured validation errors using Effect's ParseResult formatters. Additionally, a new @errors path alias was added to tsconfig.json, and various redundant comments and import paths were cleaned up across the project. I have no feedback to provide.
sendOne/sendOneFuture 메서드는 이미 제거되어 `send`로 통합되었으므로 "send 메소드로도 동일하게 사용가능" 주석 문구는 의미가 사라졌습니다. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Palbahngmiyine
force-pushed
the
sync/beta-sendOne-cleanup
branch
from
4f9564d to
6ef3982
Compare
Palbahngmiyine
changed the title
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/javascript/common/src/sms/send_sms.js의 stale 주석 한 줄을 정리합니다.send로 통합되어 있어, "send 메소드로도 동일하게 사용가능" 안내 문구(line 11)는 의미가 사라졌습니다.send만 존재)과 일치시킵니다.Changes
examples/javascript/common/src/sms/send_sms.js(1 line)// 단일 발송 예제, send 메소드로도 동일하게 사용가능→// 단일 발송 예제Test plan
rg "sendOne|sendOneFuture|send 메소드로도" examples→ 0건🤖 Generated with Claude Code