This repository was archived by the owner on Apr 14, 2026. It is now read-only.
refactor(auth): extract OAuth capture to dedicated guard service#183
Open
refactor(auth): extract OAuth capture to dedicated guard service#183
Conversation
Add OAuthCaptureGuard to enforce temporal constraint that OAuth callback params must be captured BEFORE GoRouter initializes. The guard: - Throws StateError if params accessed without capture - Throws StateError if capture() called twice - Provides descriptive error messages explaining the constraint - Includes @VisibleForTesting reset() for test isolation This makes the implicit temporal dependency explicit and testable, preventing silent failures if initialization order changes. Closes #181
runyaga
force-pushed
the
fix/181-oauth-capture-service
branch
from
fe79e8d to
5f9a150
Compare
Fix `require_trailing_commas` lint errors by reformatting multi-line throwsA() calls with proper trailing commas on the inner having() results.
WilliamKarolDiCioccio
pushed a commit
to WilliamKarolDiCioccio/runyaga_soliplex_flutter
that referenced
this pull request
Apr 13, 2026
…ate-messages fix(client): deduplicate user messages on history replay
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAuthCaptureGuardto enforce temporal constraint that OAuth callback params must be captured BEFORE GoRouter initializesStateErrorif params accessed without capture or if capture called twiceChanges
Test plan
dart analyzereports 0 issuesdart formatpassesCloses #181