This repository was archived by the owner on Apr 14, 2026. It is now read-only.
test(patrol): client-side tool calling E2E test#291
Draft
runyaga wants to merge 3 commits intorefactor/notifier-stream-setupfrom
Draft
test(patrol): client-side tool calling E2E test#291runyaga wants to merge 3 commits intorefactor/notifier-stream-setupfrom
runyaga wants to merge 3 commits intorefactor/notifier-stream-setupfrom
Conversation
Add Patrol integration test validating the full tool call lifecycle:
register get_secret_code tool, trigger model to call it, execute
client-side, and verify continuation run returns "42".
Key changes:
- patrol_helpers: add extraOverrides param for provider injection
- active_run_notifier: use createRun for continuation, new CancelToken
- agui_message_mapper: normalize empty args to '{}', add id to
ToolMessage, handle failed status
- Update mapper test for empty args normalization
With the stream drain fix, Run 1's RUN_FINISHED arrives before the continuation run. The test now counts RUN_FINISHED events and waits for the second one. Always dumps logs in finally block for diagnosis.
runyaga
force-pushed
the
test/patrol-tool-calling
branch
from
8b9cadd to
43e253e
Compare
runyaga
changed the base branch from
feat/client-tool-calling-v2
to
refactor/notifier-stream-setup
The E2E test waits for a "Continuation run" log message to confirm the tool result handoff succeeded. Add the log after createRun in _continueWithToolResults.
This was referenced Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraOverridesparameter topumpTestApp/pumpAuthenticatedTestAppfor provider injectionextraOverridesusage in patrol skillChanges
client_tool_calling_test.dart: New test — registersget_secret_codetool (returns"42"), sends prompt, asserts tool lifecycle via log-driven waits, verifies "42" in LLM response, checks performance < 90s for two-run flowpatrol_helpers.dart: Both pump helpers accept optionalList<Override> extraOverridesappended after base overridesSKILL.md: AddedextraOverridesusage docs, Riverpod 3.x import note, tool-calling log patterns tableTest plan
patrol test --device macos --target integration_test/client_tool_calling_test.dartpasses (2x)patrol test --device macos --target integration_test/smoke_test.dartpasses (no regression)flutter test— 1221 tests passdart test(soliplex_client) — 1101 tests passflutter analyze --fatal-infos— 0 issues