fix/login: override config endpoint if endpoint positional argument is given#1300
Merged
fix/login: override config endpoint if endpoint positional argument is given#1300
Conversation
- update config endpointURL if endpointURL is set either as a flag or positional argument - warn the user about endpoint conflict or that the default endpoint is being used
32c7289 to
131ac9a
Compare
BolajiOlajide
approved these changes
Apr 20, 2026
131ac9a to
89f7c8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Config would default endpoint to
https://sourcegraph.comif unset, so when login validated the positional endpoint argument against the config it would be in conflict and then tell the user that the arg they provided conflicts withhttps://sourcegraph.com, meanwhile they didn't set anything.We now:
SRC_ENDPOINTis not set and andcfg.endpointURLis nilCloses CPL-359
Test plan