Align MockHttpServletRequest.isRequestedSessionIdValid() with Servlet 6.1#36671
Open
tianhaocui wants to merge 1 commit intospring-projects:mainfrom
Open
Align MockHttpServletRequest.isRequestedSessionIdValid() with Servlet 6.1#36671tianhaocui wants to merge 1 commit intospring-projects:mainfrom
tianhaocui wants to merge 1 commit intospring-projects:mainfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
… 6.1 Change requestedSessionIdValid field from boolean (default true) to @nullable Boolean (default null). When not explicitly set via setRequestedSessionIdValid(), isRequestedSessionIdValid() now calculates the return value by checking if the requested session ID matches the current session's ID, aligning with the Servlet 6.1 specification. Closes spring-projectsgh-36631 Signed-off-by: cuitianhao <54015884+tianhaocui@users.noreply.github.com>
tianhaocui
force-pushed
the
fix-mock-session-id-valid
branch
from
70af16d to
1453996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36631
Summary
MockHttpServletRequest.isRequestedSessionIdValid()currently defaults totrue, which does not match the Servlet 6.1 specification.Changes
requestedSessionIdValidfield fromboolean(defaulttrue) to@Nullable Boolean(defaultnull)setRequestedSessionIdValid(),isRequestedSessionIdValid()now calculates the return value by checking if the requested session ID matches the current session's IDBehavior
getRequestedSessionId()returnsnull) ->isRequestedSessionIdValid()returnsfalsechangeSessionId(), requested ID no longer matches -> returnsfalsesetRequestedSessionIdValid(true/false)still works as before for explicit control