Skip to content

Include openshift-4.12 schema#201

Open
mclasmeier wants to merge 3 commits intomainfrom
mc/openshift-4.12-schema
Open

Include openshift-4.12 schema#201
mclasmeier wants to merge 3 commits intomainfrom
mc/openshift-4.12-schema

Conversation

@mclasmeier
Copy link
Copy Markdown
Contributor

@mclasmeier mclasmeier commented Apr 8, 2026

This is coming from the most recent 4.12.z release (currently 4.12.87).
OpenShift 4.12 is currently in the extended support phase in its lifecycle.

Generated using

  oc get --raw /openapi/v2 | jq --sort-keys 'del(.parameters, .paths[], .security, .securityDefinitions)' | \
  sed -Ee 's/(Authorization: Bearer sha256)~[^ ]*/\1~REDACTED/;'

Note, the sed part was required because otherwise the pre-commit check would have caught an example token in the included documentation.

Moritz Clasmeier added 3 commits April 7, 2026 14:34
This is coming from the most recent 4.12.z release (currently 4.12.87).

Generated using

  oc get --raw /openapi/v2 | jq --sort-keys 'del(.parameters, .paths[], .security, .securityDefinitions)' | sed -Ee 's/(Authorization: Bearer sha256)~[^ ]*/\1~REDACTED/;'
@mclasmeier mclasmeier requested a review from a team as a code owner April 8, 2026 10:06
@mclasmeier mclasmeier requested review from porridge and removed request for a team April 8, 2026 10:06
@porridge
Copy link
Copy Markdown
Contributor

porridge commented Apr 8, 2026

Since this is not released yet, we probably should force push master to f48c059 to remove the uncompressed file so we don't drag it around in the history forever.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this is about, but did you do it? 😅

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused, this was already part of #200, per your suggestion.
But I see that I should rebase this PR on current master so that it vanishes from this PR.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion in #200 was about the sed. This question is about the .info editing. If it's the same thing, then perhaps the README steps should also be combined?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah!
I did have a look and compared with the other files and tbh, I didn't see any need for editing. 🤷

@mclasmeier mclasmeier changed the title Mc/openshift 4.12 schema: Forgot to compress the file Include openshift-4.12 schema Apr 8, 2026
@mclasmeier mclasmeier requested a review from porridge April 8, 2026 12:01
mclasmeier pushed a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.

Reference: stackrox/helmtest#201
mclasmeier pushed a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.

Reference: stackrox/helmtest#201
mclasmeier pushed a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.

Reference: stackrox/helmtest#201
mclasmeier pushed a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.

Reference: stackrox/helmtest#201
mclasmeier pushed a commit to stackrox/stackrox that referenced this pull request Apr 8, 2026
This temporarily points to stackrox/helmtest PR #201 which adds
the openshift-4.12 schema needed for the updated tests.

Reference: stackrox/helmtest#201
Copy link
Copy Markdown

@vladbologa vladbologa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the uncompressed internal/schemas/openapi-schemas/openshift-4.12.json added in #200 be removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants