Merged
Conversation
Contributor
Author
|
/retest |
Contributor
|
@daynewlee, looks like there's a problem with the current changes. From the last run: |
|
@github-actions[bot]: The Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dcaravel
approved these changes
Apr 9, 2026
Contributor
dcaravel
left a comment
There was a problem hiding this comment.
LGTM - nice wont have to deal with whitespace breakage anymore! Don't believe the change to testcase_test.go is needed after the normalizeString addition, but no harm in keeping it.
BradLugo
approved these changes
Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee
added a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee
added a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee
added a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee
added a commit
that referenced
this pull request
Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee
added a commit
that referenced
this pull request
Apr 10, 2026
daynewlee
added a commit
that referenced
this pull request
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.