Skip to content

Fix some e2e failures#3054

Merged
daynewlee merged 7 commits intomasterfrom
yli3/fixE2e
Apr 9, 2026
Merged

Fix some e2e failures#3054
daynewlee merged 7 commits intomasterfrom
yli3/fixE2e

Conversation

@daynewlee
Copy link
Copy Markdown
Contributor

No description provided.

@daynewlee daynewlee requested a review from a team as a code owner April 7, 2026 20:30
@daynewlee
Copy link
Copy Markdown
Contributor Author

/retest

@BradLugo
Copy link
Copy Markdown
Contributor

BradLugo commented Apr 7, 2026

@daynewlee, looks like there's a problem with the current changes. From the last run:

+ e2e-tests
set -o pipefail ; \
go test -tags e2e -count=1 -timeout=30m -v ./e2etests/... | tee test-output/test.log
# github.com/stackrox/scanner/e2etests [github.com/stackrox/scanner/e2etests.test]
e2etests/sanity_test.go:156:50: feature.Description undefined (type "github.com/stackrox/scanner/api/v1".Feature has no field or method Description)
e2etests/sanity_test.go:157:52: matching.Description undefined (type *"github.com/stackrox/scanner/api/v1".Feature has no field or method Description)
e2etests/sanity_test.go:196:9: undefined: strings
FAIL	github.com/stackrox/scanner/e2etests [build failed]
FAIL
make: *** [Makefile:332: e2e-tests] Error 1

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 8, 2026

@github-actions[bot]: The /retest command does not accept any targets.
The following commands are available to trigger optional jobs:

/test e2e-tests
/test slim-e2e-tests

Use /test all to run all jobs.

Details

In response to this:

/retest scanner-on-push

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@daynewlee daynewlee requested review from BradLugo, dcaravel and jvdm April 9, 2026 00:39
Copy link
Copy Markdown
Contributor

@dcaravel dcaravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice wont have to deal with whitespace breakage anymore! Don't believe the change to testcase_test.go is needed after the normalizeString addition, but no harm in keeping it.

Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
@daynewlee daynewlee merged commit d689ef7 into master Apr 9, 2026
39 checks passed
@daynewlee daynewlee deleted the yli3/fixE2e branch April 9, 2026 14:14
daynewlee added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee added a commit that referenced this pull request Apr 9, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
daynewlee added a commit that referenced this pull request Apr 10, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
Co-authored-by: David House <105243888+davdhacs@users.noreply.github.com>
daynewlee added a commit that referenced this pull request Apr 10, 2026
Co-authored-by: David Caravello <119438707+dcaravel@users.noreply.github.com>
Co-authored-by: David House <105243888+davdhacs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants