Conversation
Our variant IDs are nondescript, inconsistent, and unintuitive. Add some notes to the Makefiles to more quickly identify them. Some extra notes: - gaze17-3060 doesn't exist - It was copied from gaze16 variants - lemp13 only had a 14" option with different keyboard layouts - I've chosen to label the original layout "cursed" - Some models are a refresh without any significant changes - darp10/darp11, oryp6/oryp7 - Potential to merge them at some point? Signed-off-by: Tim Crawford <tcrawford@system76.com>
crawfxrd
force-pushed
the
dev/comment-variants
branch
from
1ab8bdc to
6d5b936
Compare
leviport
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our variant IDs are nondescript, inconsistent, and unintuitive.
Add some notes to the Makefiles to more quickly identify them.
Some extra notes:
gaze17-3060doesn't existgaze16variantslemp13only had a 14" option with different keyboard layoutsdarp10/darp11,oryp6/oryp7