Conversation
What was broken Saved design challenges could still lose the visible copilot and assigned reviewers after a full refresh or when reopening edit mode, and the review configuration could surface validation noise even though the persisted assignments and scorecards already existed. Root cause (if identifiable) The earlier refresh fix still stopped the initial persisted-resource hydration path as soon as mount-time form normalization marked the editor dirty. In the remaining legacy payload path, a saved copilot handle could also be replaced by a member-id-only resource match. What was changed Allowed the first persisted-resource hydration pass to continue during the initial normalization window while keeping the existing dirty-form guards for later user edits. Also preserved an already hydrated copilot handle when the refreshed resources only provide a legacy member-id match, and documented the behavior in the challenge editor README. Any added/updated tests Added ChallengeEditorForm coverage for rehydrating persisted copilot and reviewer assignments when a compatibility field dirties the form during initial hydration.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Saved design challenges could still lose the visible copilot and assigned reviewers after a full refresh or when reopening edit mode, and the review configuration could surface validation noise even though the persisted assignments and scorecards already existed.
Root cause (if identifiable)
The earlier refresh fix still stopped the initial persisted-resource hydration path as soon as mount-time form normalization marked the editor dirty. In the remaining legacy payload path, a saved copilot handle could also be replaced by a member-id-only resource match.
What was changed
Allowed the first persisted-resource hydration pass to continue during the initial normalization window while keeping the existing dirty-form guards for later user edits. Also preserved an already hydrated copilot handle when the refreshed resources only provide a legacy member-id match, and documented the behavior in the challenge editor README.
Any added/updated tests
Added ChallengeEditorForm coverage for rehydrating persisted copilot and reviewer assignments when a compatibility field dirties the form during initial hydration.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/
What's in this PR?