Skip to content

Add comprehensive webapp testing skills#3373

Closed
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/update-skills-1776170297
Closed

Add comprehensive webapp testing skills#3373
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin/update-skills-1776170297

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Documents the complete webapp testing procedure including build steps, dev server startup, operational testing with reference projects, and comprehensive UI testing checklist.

Devin Session: https://app.devin.ai/sessions/d9fa9953b9bf40e5a8d12b8f5ba5b86b

Co-authored-by: Eric Allam <eallam@icloud.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 14, 2026

⚠️ No Changeset found

Latest commit: b735ca8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution! We require all external PRs to be opened in draft status first so you can address CodeRabbit review comments and ensure CI passes before requesting a review. Please re-open this PR as a draft. See CONTRIBUTING.md for details.

@github-actions github-actions bot closed this Apr 14, 2026
@ericallam ericallam reopened this Apr 14, 2026
Copy link
Copy Markdown
Contributor Author

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

View 2 additional findings in Devin Review.

Open in Devin Review


## Comprehensive UI Testing Checklist

### Sidebar Pages (22 pages)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Sidebar page count claims 22 but only lists 20 items

The heading at line 78 says "Sidebar Pages (22 pages)" but the actual list that follows contains only 20 bullet points (Tasks, Runs, Run Detail, Batches, Schedules, Queues, Waitpoint tokens, Deployments, Test, Bulk actions, API keys, Environment variables, Alerts, Preview branches, Regions, Limits, Project settings General, Project settings Integrations, Organization settings, Team). An AI agent following this checklist would either think it missed 2 pages or could get confused reconciling the count with the list.

Suggested change
### Sidebar Pages (22 pages)
### Sidebar Pages (20 pages)
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

- **Project/Org switcher**: Org info, projects, New project, New org, Account, Logout

## Tips
- The `pnpm run dev --filter webapp` command might not work reliably. Use the manual build + `remix dev` approach instead.
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Skill file contradicts AGENTS.md, CLAUDE.md, and CONTRIBUTING.md on standard dev workflow

Line 111 states: "The pnpm run dev --filter webapp command might not work reliably. Use the manual build + remix dev approach instead." This directly contradicts the standard dev workflow documented in all three rule files: AGENTS.md ("Launch the development server: pnpm run dev --filter webapp"), CLAUDE.md ("pnpm run dev --filter webapp # Run webapp"), and CONTRIBUTING.md ("You can run the app with: pnpm run dev --filter webapp"). An agent following this skill file would skip the standard approach in favor of a manual multi-step build process, deviating from the canonical workflow.

Suggested change
- The `pnpm run dev --filter webapp` command might not work reliably. Use the manual build + `remix dev` approach instead.
- You can start the webapp with `pnpm run dev --filter webapp` as documented in AGENTS.md and CONTRIBUTING.md. If that doesn't work, fall back to the manual build + `remix dev` approach described above.
Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

- The `pnpm run dev --filter webapp` command might not work reliably. Use the manual build + `remix dev` approach instead.
- If port 3030 is already in use: `fuser -k 3030/tcp`
- The trigger CLI must authenticate against localhost separately from cloud: use `-a http://localhost:3030 --profile local`
- `pnpm run db:seed` may hang - it's not required if migrations are applied
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚩 db:seed guidance contradicts CLAUDE.md

Line 114 says "pnpm run db:seed may hang - it's not required if migrations are applied." However, CLAUDE.md:12 explicitly states pnpm run db:seed # Seed the database (required for reference projects). While the seed step may indeed be flaky in some environments, the blanket statement that it's "not required" conflicts with the CLAUDE.md guidance that it's required for reference projects. An agent skipping the seed step and then trying to test with the hello-world reference project might encounter missing data. This is borderline between a documentation inconsistency and a rule violation — I chose to flag it as an analysis since CLAUDE.md uses softer language ("required for reference projects") rather than a hard rule.

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@ericallam ericallam marked this pull request as draft April 14, 2026 12:40
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for your contribution! We require all external PRs to be opened in draft status first so you can address CodeRabbit review comments and ensure CI passes before requesting a review. Please re-open this PR as a draft. See CONTRIBUTING.md for details.

@github-actions github-actions bot closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant