Skip to content

fix(run-engine): distinguish oneTimeUseToken P2002 from idempotency key collision #3374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ericallam wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(run-engine): distinguish oneTimeUseToken P2002 from idempotency key collision #3374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions internal-packages/run-engine/src/engine/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ import { RunQueue } from "../run-queue/index.js";
import { RunQueueFullKeyProducer } from "../run-queue/keyProducer.js";
import { AuthenticatedEnvironment, MinimalAuthenticatedEnvironment } from "../shared/index.js";
import { BillingCache } from "./billingCache.js";
import { NotImplementedError, RunDuplicateIdempotencyKeyError } from "./errors.js";
import { NotImplementedError, RunDuplicateIdempotencyKeyError, RunOneTimeUseTokenError } from "./errors.js";
import { EventBus, EventBusEvents } from "./eventBus.js";
import { RunLocker } from "./locking.js";
import { getFinalRunStatuses } from "./statuses.js";
Expand Down Expand Up @@ -709,15 +709,25 @@ export class RunEngine {
});

if (error.code === "P2002") {
this.logger.debug("engine.trigger(): throwing RunDuplicateIdempotencyKeyError", {
const target = (error.meta as Record<string, unknown>)?.target;
const targetFields = Array.isArray(target) ? target : [];

this.logger.debug("engine.trigger(): P2002 unique constraint violation", {
code: error.code,
message: error.message,
meta: error.meta,
target: targetFields,
idempotencyKey,
environmentId: environment.id,
});

//this happens if a unique constraint failed, i.e. duplicate idempotency
if (targetFields.includes("oneTimeUseToken")) {
throw new RunOneTimeUseTokenError(
`One-time use token has already been used`
);
}

// Only idempotency key collisions should be retried
throw new RunDuplicateIdempotencyKeyError(
`Run with idempotency key ${idempotencyKey} already exists`
);
Expand Down
Loading