More carefully define two-locus haplotypes in docs#3447
Merged
petrelharp merged 1 commit intotskit-dev:mainfrom Apr 20, 2026
Merged
More carefully define two-locus haplotypes in docs#3447petrelharp merged 1 commit intotskit-dev:mainfrom
petrelharp merged 1 commit intotskit-dev:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3447 +/- ##
=======================================
Coverage 91.66% 91.66%
=======================================
Files 38 38
Lines 32184 32184
Branches 5150 5150
=======================================
Hits 29503 29503
Misses 2348 2348
Partials 333 333
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
petrelharp
reviewed
Apr 15, 2026
petrelharp
reviewed
Apr 15, 2026
Contributor
|
Thanks for this. Good start, needs more preciseness. |
Contributor
Author
|
Gotta run to some things today, but tried to add some preciseness here. Thanks Peter. |
petrelharp
reviewed
Apr 17, 2026
petrelharp
reviewed
Apr 17, 2026
petrelharp
reviewed
Apr 17, 2026
Contributor
|
A few more suggestions... |
petrelharp
approved these changes
Apr 20, 2026
Contributor
petrelharp
left a comment
petrelharp
left a comment
There was a problem hiding this comment.
This is a helpful improvement. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in #3445, there is room for improvement in defining the haplotype counts that are passed to the summary functions in the two-locus statistics methods. This more carefully defines those, following advice from @petrelharp, and clarifies the number of times summary functions are called for a given number of alleles at the left and right loci.