Conversation
|
This PR addresses uselagoon/lagoon-product#3 |
3647698 to
44d04c5
Compare
44d04c5 to
90bd469
Compare
| volumeMounts = append(volumeMounts, corev1.VolumeMount{ | ||
| Name: volume.Name, | ||
| ReadOnly: false, | ||
| MountPath: "/storage/" + volume.Name, |
There was a problem hiding this comment.
Is there anywhere where this is actually documented? The fact that this is where things will get mounted? More a question than a request or whatever.
There was a problem hiding this comment.
The only place I've seen it documented is in the issue on the Product board?
| lagoonEnvironmentVariables := &[]helpers.LagoonEnvironmentVariable{} | ||
| _ = json.Unmarshal(lagoonTask.Spec.Project.Variables.Project, lagoonProjectVariables) | ||
| _ = json.Unmarshal(lagoonTask.Spec.Project.Variables.Environment, lagoonEnvironmentVariables) | ||
| // checking the various ways rootless could be enabled - not sure if this is overkill? |
There was a problem hiding this comment.
its intense, but it is required in some form to check these variables for the feature flag to ensure the task pod gets the right fsgroup options
There was a problem hiding this comment.
Yeah I wasn't sure if this was overkill or not, I just replicated here what we're doing in the build deploy generator to make sure we're covering all the cases. I can take a look and see if there's a nicer way to it
There was a problem hiding this comment.
for reference, this is the original source
remote-controller/internal/controllers/v1beta2/build_helpers.go
Lines 420 to 429 in d33ac54
There was a problem hiding this comment.
i think its fine to leave it the way it is, unless you can figure out a better refactor that accomplishes the same result :D
Checklist
Various changs to support the project cloning workflow
projectclone&projectclonerestoretasks in the consumer + running the clone task in tasks_handlerRequired for uselagoon/lagoon#4072