tests: split elf coverage into no-reloc control and reloc gate#70
tests: split elf coverage into no-reloc control and reloc gate#70jlinenkohl wants to merge 1 commit intovarnish:masterfrom
Conversation
|
I don't quite understand this PR. Most unit tests are already statically linked binaries, so adding a return 123; test is not adding anything new or testing any new code paths. |
fwsGonzo
left a comment
There was a problem hiding this comment.
Adding a new test that just returns 123 is not a new codepath. Most unit tests are static ELFs already. We could maybe merge the CWD change to avoid a leak with get_current_dir_name().
a52f529 to
63dc20f
Compare
|
I've pulled this back to draft for now as this was submitted too soon as a batch with the others. I had added some test gates for working on relocation support and this was not ready to go upstream. This was pushed up because of the CWD fix but was not supposed to include the rest. I do appreciate your feedback though and have noted to include that minor fix in a subsequent update. Also, about to propose a merge of a different fix in PR71 that caused a SIGSEGV. I discovered it while doing relocation work. |
Summary
[ELF][no-reloc])[ELF][reloc])Why
Validation
cd tests && bash run_unit_tests.sh -R test_elfDepends on
Stack Context
Test Evidence
cd tests && bash run_unit_tests.sh-> 8/8 passed(cd guest/tests && bash build.sh) && ./build/tinytest guest/tests/glibc_test-> passedPR-Scoped Command
cd tests && bash run_unit_tests.sh -R test_elf