README.md - Android version corrected#100
Open
nachfuellbar wants to merge 1 commit intowaydroid:masterfrom
Open
README.md - Android version corrected#100nachfuellbar wants to merge 1 commit intowaydroid:masterfrom
nachfuellbar wants to merge 1 commit intowaydroid:masterfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the README to reflect that the Android system image is now based on Android 13 instead of Android 11. A review comment suggests improving the phrasing and grammar of the updated sentence for better clarity and idiomatic usage.
| The Android inside the container has direct access to needed hardwares. | ||
|
|
||
| The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 11. | ||
| The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 13. |
There was a problem hiding this comment.
The phrasing in this sentence can be improved for better clarity and grammatical correctness. "LineageOS" is a proper noun and typically does not require the definite article "the" in this context. Additionally, "The current image" is more idiomatic than "The used image".
Suggested change
| The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 13. | |
| The Android runtime environment ships with a minimal customized Android system image based on [LineageOS](https://lineageos.org). The current image is based on Android 13. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.