Skip to content

README.md - Android version corrected#100

Open
nachfuellbar wants to merge 1 commit intowaydroid:masterfrom
nachfuellbar:patch-1
Open

README.md - Android version corrected#100
nachfuellbar wants to merge 1 commit intowaydroid:masterfrom
nachfuellbar:patch-1

Conversation

@nachfuellbar
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README to reflect that the Android system image is now based on Android 13 instead of Android 11. A review comment suggests improving the phrasing and grammar of the updated sentence for better clarity and idiomatic usage.

The Android inside the container has direct access to needed hardwares.

The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 11.
The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 13.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrasing in this sentence can be improved for better clarity and grammatical correctness. "LineageOS" is a proper noun and typically does not require the definite article "the" in this context. Additionally, "The current image" is more idiomatic than "The used image".

Suggested change
The Android runtime environment ships with a minimal customized Android system image based on the [LineageOS](https://lineageos.org). The used image is currently based on Android 13.
The Android runtime environment ships with a minimal customized Android system image based on [LineageOS](https://lineageos.org). The current image is based on Android 13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant