Fix embedded images built with the clang compiler by danielinux · Pull Request #730 · wolfSSL/wolfBoot

danielinux · 2026-03-19T22:43:06Z

zd21378

Copilot

Pull request overview

This PR addresses oversized/sparse embedded images produced when building with clang by adjusting linking and objcopy behavior for clang-based builds.

Changes:

Add clang-specific objcopy section filtering to avoid producing huge sparse binary/hex/srec outputs.
Switch clang builds to use the GNU linker driver to preserve LMAs in the linker script.
Relax clang build warnings around unknown attributes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
test-app/Makefile	Introduces clang-specific `objcopy` flags and applies them to image artifact generation to prevent sparse outputs.
arch.mk	Changes clang toolchain linking to use GNU linker driver and adds clang warning suppressions for unknown attributes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test-app/Makefile

arch.mk

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arch.mk

test-app/Makefile

Makefile

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arch.mk

.github/workflows/test-build.yml

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

arch.mk

.github/workflows/test-build.yml

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test-app/Makefile

options.mk

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/clang_sections.S

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

test-app/Makefile

src/clang_sections.S

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/clang_sections.S

.github/workflows/test-build.yml

Copilot

Pull request overview

Copilot reviewed 21 out of 21 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

options.mk

Copilot

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/clang_sections.S

test-app/ARM-stm32h7.ld

options.mk

arch.mk

dgarske

🐺 Skoll Code Review

Overall recommendation: REQUEST_CHANGES
Findings: 3 total — 2 posted, 2 skipped

Posted findings

[High] Missing || operator between CI condition lines causes expression parse error — .github/workflows/test-build.yml:56-57
[Medium] Consider using CLANG_MULTILIB_FLAGS as a shared pattern to reduce duplication — options.mk:807-809,860-862

Skipped findings

[Info] Whitespace-only change in stm32l4.ld adds blank line
[Medium] Consider using CLANG_MULTILIB_FLAGS as a shared pattern to reduce duplication

Review generated by Skoll via openclaw

.github/workflows/test-build.yml

Copilot AI review requested due to automatic review settings March 19, 2026 22:43

Copilot AI reviewed Mar 19, 2026

View reviewed changes

test-app/Makefile Outdated Show resolved Hide resolved

test-app/Makefile Outdated Show resolved Hide resolved

arch.mk Show resolved Hide resolved

Copilot started reviewing on behalf of danielinux March 19, 2026 23:48 View session

Copilot AI review requested due to automatic review settings March 23, 2026 17:34

Copilot AI reviewed Mar 23, 2026

View reviewed changes

Copilot started reviewing on behalf of danielinux March 23, 2026 17:56 View session

Copilot AI review requested due to automatic review settings March 23, 2026 18:41

Copilot AI reviewed Mar 23, 2026

View reviewed changes

arch.mk Outdated Show resolved Hide resolved

arch.mk Outdated Show resolved Hide resolved

.github/workflows/test-build.yml Outdated Show resolved Hide resolved

Copilot started reviewing on behalf of danielinux March 23, 2026 19:58 View session

Copilot AI review requested due to automatic review settings March 25, 2026 05:09

danielinux force-pushed the clang-linker branch from 9c7d22d to aeee273 Compare March 25, 2026 05:09

Copilot started reviewing on behalf of danielinux March 25, 2026 05:13 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

arch.mk Outdated Show resolved Hide resolved

.github/workflows/test-build.yml Outdated Show resolved Hide resolved

.github/workflows/test-build.yml Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 31, 2026 21:15

Copilot started reviewing on behalf of mattia-moffa March 31, 2026 21:20 View session

Copilot AI reviewed Mar 31, 2026

View reviewed changes

test-app/Makefile Outdated Show resolved Hide resolved

options.mk Show resolved Hide resolved

Copilot AI review requested due to automatic review settings April 3, 2026 14:00

Copilot started reviewing on behalf of mattia-moffa April 3, 2026 14:07 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

src/clang_sections.S Show resolved Hide resolved

Copilot AI review requested due to automatic review settings April 3, 2026 15:49

Copilot AI reviewed Apr 3, 2026

View reviewed changes

test-app/Makefile Outdated Show resolved Hide resolved

src/clang_sections.S Outdated Show resolved Hide resolved

danielinux added 9 commits April 3, 2026 18:09

Fix embedded images built with the clang compiler

ed15e3a

Added explicit discard list for clang compiler

6082543

Added clang pass for arm build tests

cd556ce

Discard volatile sections during app objcopy when compiling with clang

f6ec476

Fix stdlib in clang, limit test to a few targets

f7b2e5a

Exclude stm32c0 (too small for clang) and stm32h5 (no ARMORED support)

9982734

Concentrate flags for clang in arch.mk

8583a87

Fixed Clang sections in TZEN images

bcd4d8b

CLANG: fix sparse image for test-app in trustzone

ce24cd2

Use llvm-ar, llvm-objcopy, llvm-size when USE_CLANG=1

a0a3dae

Copilot AI review requested due to automatic review settings April 3, 2026 16:09

mattia-moffa force-pushed the clang-linker branch from 0f77eac to a0a3dae Compare April 3, 2026 16:09

Copilot started reviewing on behalf of mattia-moffa April 3, 2026 16:12 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

src/clang_sections.S Outdated Show resolved Hide resolved

.github/workflows/test-build.yml Outdated Show resolved Hide resolved

mattia-moffa added 2 commits April 3, 2026 18:51

Update test container to 1.3

5cd5a19

Explicitly place .keystore

8bfdf5b

Copilot AI review requested due to automatic review settings April 3, 2026 17:19

Copilot started reviewing on behalf of mattia-moffa April 3, 2026 17:19 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

Fix CI tests

e01c613

mattia-moffa self-assigned this Apr 3, 2026

Address Copilot review

497295f

Copilot AI review requested due to automatic review settings April 9, 2026 14:18

Copilot started reviewing on behalf of mattia-moffa April 9, 2026 14:21 View session

Copilot AI reviewed Apr 9, 2026

View reviewed changes

options.mk Outdated Show resolved Hide resolved

options.mk Outdated Show resolved Hide resolved

mattia-moffa added 2 commits April 9, 2026 16:44

Replace tabs with spaces in options.mk

6fda799

Simplify comment

53c9015

Copilot AI review requested due to automatic review settings April 9, 2026 14:48

Copilot AI reviewed Apr 9, 2026

View reviewed changes

src/clang_sections.S Show resolved Hide resolved

test-app/ARM-stm32h7.ld Show resolved Hide resolved

options.mk Show resolved Hide resolved

arch.mk Show resolved Hide resolved

Copilot started reviewing on behalf of mattia-moffa April 9, 2026 15:01 View session

mattia-moffa assigned wolfSSL-Bot and unassigned mattia-moffa Apr 9, 2026

dgarske requested changes Apr 9, 2026

View reviewed changes

.github/workflows/test-build.yml Outdated Show resolved Hide resolved

dgarske assigned danielinux Apr 9, 2026

Fix GH workflow syntax error

941d3f2

danielinux requested a review from dgarske April 13, 2026 17:51

danielinux removed their assignment Apr 13, 2026

dgarske approved these changes Apr 13, 2026

View reviewed changes

dgarske merged commit 58c2e04 into wolfSSL:master Apr 13, 2026
369 checks passed

Conversation

danielinux commented Mar 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgarske left a comment

Choose a reason for hiding this comment

🐺 Skoll Code Review

Posted findings